Fix confusion between stubs for google.protobuf and google.cloud #10609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we used `google` as a package perfix for `google.protobuf`. That wasn't correct, since there are other packages in the Google namespace, such as `google.cloud`. This fixes the prefix to to be `google.protobuf`. Fixes #10601.
|
Diff from mypy_primer, showing the effect of this PR on open source code: scrapy (https://github.com/scrapy/scrapy.git)
- scrapy/extensions/feedexport.py:180: error: Library stubs not installed for "google.cloud.storage" (or incompatible with Python 3.8)
- scrapy/extensions/feedexport.py:180: note: Hint: "python3 -m pip install types-protobuf"
- scrapy/pipelines/files.py:195: error: Library stubs not installed for "google.cloud" (or incompatible with Python 3.8)
- scrapy/utils/test.py:27: error: Library stubs not installed for "google.cloud" (or incompatible with Python 3.8)
- scrapy/utils/test.py:103: error: Library stubs not installed for "google.cloud.storage" (or incompatible with Python 3.8)
- tests/test_feedexport.py:420: error: Library stubs not installed for "google.cloud.storage" (or incompatible with Python 3.8)
core (https://github.com/home-assistant/core.git)
- homeassistant/components/google_cloud/tts.py:7: error: Library stubs not installed for "google.cloud" (or incompatible with Python 3.8) [import]
- homeassistant/components/google_cloud/tts.py:7: note: Hint: "python3 -m pip install types-protobuf"
prefect (https://github.com/PrefectHQ/prefect.git)
- src/prefect/engine/results/gcs_result.py:6: error: Library stubs not installed for "google" (or incompatible with Python 3.8)
- src/prefect/engine/results/gcs_result.py:6: error: Library stubs not installed for "google.cloud" (or incompatible with Python 3.8)
- src/prefect/engine/results/gcs_result.py:6: note: Hint: "python3 -m pip install types-protobuf"
|
ilevkivskyi
approved these changes
Jun 9, 2021
JukkaL
added a commit
that referenced
this pull request
Jun 10, 2021
) Previously we used `google` as a package prefix for `google.protobuf`. That wasn't correct, since there are other packages in the Google namespace, such as `google.cloud`. This fixes the prefix to to be `google.protobuf`. Fixes #10601.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we used
googleas the package prefix forgoogle.protobuf.That wasn't correct, since there are other, unrelated packages in the Google
namespace, such as
google.cloud.This fixes the prefix to to be
google.protobuf.Fixes #10601.