Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-93464: [Enum] Add versionchanged tag #99997

Merged
merged 2 commits into from
Dec 5, 2022
Merged

gh-93464: [Enum] Add versionchanged tag #99997

merged 2 commits into from
Dec 5, 2022

Conversation

ethanfurman
Copy link
Member

@ethanfurman ethanfurman commented Dec 4, 2022 •
edited by bedevere-bot
Loading

@ethanfurman ethanfurman added docs Documentation in the Doc dir skip news 3.11 only security fixes 3.12 bugs and security fixes needs backport to 3.11 only security fixes labels Dec 4, 2022
@ethanfurman ethanfurman self-assigned this Dec 4, 2022
@bedevere-bot bedevere-bot mentioned this pull request Dec 4, 2022
Closed
CAM-Gerlach
CAM-Gerlach reviewed Dec 5, 2022
View reviewed changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One textual suggestion, otherwise LGTM, thanks!

Doc/library/enum.rst Outdated Show resolved Hide resolved
@ethanfurman @CAM-Gerlach
Update Doc/library/enum.rst
55c2930 
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
@ethanfurman
Copy link
Member Author

Thanks, that's much better.

CAM-Gerlach
CAM-Gerlach approved these changes Dec 5, 2022
View reviewed changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hugovk hugovk merged commit e3a3863 into python:main Dec 5, 2022
@miss-islington
Copy link
Contributor

Thanks @ethanfurman for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-100004 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Dec 5, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 5, 2022
@ethanfurman @CAM-Gerlach @miss-islington
pythongh-93464: [Enum] Add versionchanged tag (pythonGH-99997)
f74d210 
(cherry picked from commit e3a3863)

Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
miss-islington added a commit that referenced this pull request Dec 5, 2022
@miss-islington @ethanfurman @CAM-Gerlach
gh-93464: [Enum] Add versionchanged tag (GH-99997)
7f2bcc7 
(cherry picked from commit e3a3863)

Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
@ethanfurman ethanfurman deleted the enum-auto branch February 1, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CAM-Gerlach CAM-Gerlach CAM-Gerlach approved these changes

@hugovk hugovk hugovk approved these changes

Assignees

@ethanfurman ethanfurman

Labels
3.11 only security fixes 3.12 bugs and security fixes docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ethanfurman @miss-islington @bedevere-bot @hugovk @CAM-Gerlach