Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-99957: Add frozen_default parameter on dataclass_transform #99958

Merged
merged 7 commits into from
Dec 6, 2022

Conversation

debonte
Copy link
Contributor

@debonte debonte commented Dec 3, 2022

Fix #99957

Add new frozen_default parameter on dataclass_transform in typing.py.
Update docs and tests.

@JelleZijlstra, @NeilGirdhar, @erictraut, @hauntsaninja, @pradeep90

Copy link
Contributor

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me, though you'll need the news entry (might even be worth a What's New bullet point as well).

Lib/typing.py Outdated Show resolved Hide resolved
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@debonte
Copy link
Contributor Author

debonte commented Dec 6, 2022

@JelleZijlstra, is this good to merge now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add frozen_default parameter on dataclass_transform
5 participants