[3.11] gh-93464: [Enum] fix auto() failure during multiple assignment (GH-99148) #99149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ythonGH-99148) * fix auto() failure during multiple assignment i.e. `ONE = auto(), 'text'` will now have `ONE' with the value of `(1, 'text')`. Before it would have been `(<an auto instance>, 'text')` (cherry picked from commit 8feb7ab) Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
ethanfurman
approved these changes
Nov 6, 2022
|
@pablogsal With your approval I'd like to merge this into 3.11.1. |
|
Apparently I cannot give my own approval or miss-islington will auto-merge. Ah, I bet I should have removed the |
|
Just to note, some users (e.g. @layday ) were confused by the fact that it didn't work in the current 3.11.0 but was is now documented in the docs without a
Yeah, it automerges in that case AFAIK.
I've also been told that thou shalt not touch the bot labels, or thou shalt be cast into the gorge of eternal peril... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i.e.
ONE = auto(), 'text'will now haveONE' with the value of(1,'text')
. Before it would have been(, 'text')`(cherry picked from commit 8feb7ab)
Co-authored-by: Ethan Furman ethan@stoneleaf.us