Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-96997: Clarify the contract of PyMem_SetAllocator() #98977

Merged
merged 2 commits into from
Nov 2, 2022
Merged

gh-96997: Clarify the contract of PyMem_SetAllocator() #98977

merged 2 commits into from
Nov 2, 2022

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Nov 1, 2022 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Nov 1, 2022
Closed
@bedevere-bot bedevere-bot added awaiting core review docs Documentation in the Doc dir skip news labels Nov 1, 2022
ericsnowcurrently
ericsnowcurrently approved these changes Nov 2, 2022
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericsnowcurrently
Copy link
Member

Thanks for working on this.

@pablogsal @ericsnowcurrently
Update Doc/c-api/memory.rst
f93f7f8 
Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
@pablogsal pablogsal added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes needs backport to 3.9 only security fixes labels Nov 2, 2022
@pablogsal pablogsal merged commit c053284 into python:main Nov 2, 2022
@pablogsal pablogsal deleted the gh-96997 branch November 2, 2022 21:49
@miss-islington
Copy link
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10, 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-99027 is a backport of this pull request to the 3.11 branch.

@miss-islington
Copy link
Contributor

Sorry, @pablogsal, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker c053284e3930027847d5adf99efcb1aa5ccbacd1 3.9

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Nov 2, 2022
@bedevere-bot
Copy link

GH-99028 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Nov 2, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 2, 2022
@pablogsal @miss-islington
pythongh-96997: Clarify the contract of PyMem_SetAllocator() (pythonG…
e781220 
…H-98977)

(cherry picked from commit c053284)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 2, 2022
@pablogsal @miss-islington
pythongh-96997: Clarify the contract of PyMem_SetAllocator() (pythonG…
8c2aef6 
…H-98977)

(cherry picked from commit c053284)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
miss-islington added a commit that referenced this pull request Nov 2, 2022
@miss-islington @pablogsal
gh-96997: Clarify the contract of PyMem_SetAllocator() (GH-98977)
6cf30c6 
(cherry picked from commit c053284)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
miss-islington added a commit that referenced this pull request Nov 2, 2022
@miss-islington @pablogsal
gh-96997: Clarify the contract of PyMem_SetAllocator() (GH-98977)
88736db 
(cherry picked from commit c053284)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@ZeroIntensity ZeroIntensity removed the needs backport to 3.9 only security fixes label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

@encukou encukou Awaiting requested review from encukou

Assignees

@pablogsal pablogsal

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pablogsal @ericsnowcurrently @miss-islington @bedevere-bot @ZeroIntensity