Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-97008: Add a Python implementation of AttributeError and NameError suggestions #97022

Merged
merged 12 commits into from
Oct 4, 2022

Conversation

ambv
Copy link
Contributor

@ambv ambv commented Sep 22, 2022

Relevant tests moved from test_exceptions to test_traceback to be able to compare both implementations.

Co-authored-by: Carl Friedrich Bolz-Tereick cfbolz@gmx.de

…eError suggestions

Relevant tests moved from test_exceptions to test_traceback to be able to
compare both implementations.

Co-authored-by: Carl Friedrich Bolz-Tereick <cfbolz@gmx.de>
Copy link
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I left a comment with a nit

@ambv ambv merged commit bbc7cd6 into python:main Oct 4, 2022
@ambv ambv deleted the levenshtein branch October 4, 2022 22:31
mpage pushed a commit to mpage/cpython that referenced this pull request Oct 11, 2022
…eError suggestions (python#97022)

Relevant tests moved from test_exceptions to test_traceback to be able to
compare both implementations.

Co-authored-by: Carl Friedrich Bolz-Tereick <cfbolz@gmx.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants