Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-91323: Revert "Allow overriding a future compliance check in asyncio.Task (GH-32197)" #95442

Merged
merged 2 commits into from
Aug 4, 2022
Merged

gh-91323: Revert "Allow overriding a future compliance check in asyncio.Task (GH-32197)" #95442

merged 2 commits into from
Aug 4, 2022

Conversation

ambv
Copy link
Contributor

@ambv ambv commented Jul 29, 2022 •
edited by bedevere-bot
Loading

@ambv ambv requested review from 1st1 and asvetlov as code owners July 29, 2022 15:48
@ambv ambv added the skip news label Jul 29, 2022
@ambv
Copy link
Contributor Author

ambv commented Jul 29, 2022

I marked this as "skip news" as the original change wasn't mentioned in the change log.

@ambv ambv added the needs backport to 3.11 only security fixes label Jul 29, 2022
@ambv ambv changed the title Revert "bpo-47167: Allow overriding a future compliance check in asyncio.Task (GH-32197)" bpo-47167: Revert "Allow overriding a future compliance check in asyncio.Task (GH-32197)" Jul 29, 2022
@ambv ambv changed the title bpo-47167: Revert "Allow overriding a future compliance check in asyncio.Task (GH-32197)" gh-91323: Revert "Allow overriding a future compliance check in asyncio.Task (GH-32197)" Jul 29, 2022
1st1
1st1 approved these changes Jul 29, 2022
View reviewed changes
Copy link
Member

@1st1 1st1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, according to #91323 (comment) this change isn't really needed.

I don't think it's much useful for anything else and I think the bar for adding new APIs to Tasks/Future is very high. Let's drop it for now. cc @asvetlov

@arhadthedev arhadthedev mentioned this pull request Jul 29, 2022
Merged
@ambv ambv merged commit 0342c93 into python:main Aug 4, 2022
@miss-islington
Copy link
Contributor

Thanks @ambv for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@ambv ambv deleted the revert-gh-32197 branch August 4, 2022 13:51
@bedevere-bot
Copy link

GH-95652 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 4, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 4, 2022
@ambv @miss-islington
pythongh-91323: Revert "Allow overriding a future compliance check in…
5202170 
… asyncio.Task (pythonGH-32197)" (pythonGH-95442)

This reverts commit d4bb38f.
(cherry picked from commit 0342c93)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
ambv added a commit that referenced this pull request Aug 4, 2022
@miss-islington @ambv
gh-91323: Revert "Allow overriding a future compliance check in async…
5ac3d0f 
…io.Task (GH-32197)" (GH-95442) (GH-95652)

This reverts commit d4bb38f.
(cherry picked from commit 0342c93)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@ambv ambv restored the revert-gh-32197 branch August 4, 2022 16:41
@ambv ambv deleted the revert-gh-32197 branch August 5, 2022 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1st1 1st1 1st1 approved these changes

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ambv @miss-islington @bedevere-bot @1st1