Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-94630: Fixup sqlite3 argument spec docs for connection execute* methods #95319

Merged
merged 1 commit into from
Jul 27, 2022
Merged

gh-94630: Fixup sqlite3 argument spec docs for connection execute* methods #95319

merged 1 commit into from
Jul 27, 2022

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jul 27, 2022 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added awaiting core review docs Documentation in the Doc dir skip news labels Jul 27, 2022
@erlend-aasland erlend-aasland added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Jul 27, 2022
@erlend-aasland
Copy link
Contributor Author

I consider this a trivial doc update; I'll merge it as soon as the CI is green.

Note, the executemany fixup corrects a small doc bug: the second argument is not optional; it is required.

@erlend-aasland erlend-aasland merged commit 2b37395 into python:main Jul 27, 2022
@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@erlend-aasland erlend-aasland deleted the sqlite-doc-arg-spec branch July 27, 2022 12:46
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 27, 2022
@erlend-aasland @miss-islington
pythongh-94630: Fixup sqlite3 argument spec docs for connection execu…
c79d411 
…te* methods (pythonGH-95319)

(cherry picked from commit 2b37395)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 27, 2022
@bedevere-bot
Copy link

GH-95321 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 27, 2022
@erlend-aasland @miss-islington
pythongh-94630: Fixup sqlite3 argument spec docs for connection execu…
263642c 
…te* methods (pythonGH-95319)

(cherry picked from commit 2b37395)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
@bedevere-bot
Copy link

GH-95322 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jul 27, 2022
@erlend-aasland erlend-aasland mentioned this pull request Jul 27, 2022
Closed
miss-islington added a commit that referenced this pull request Jul 27, 2022
@miss-islington @erlend-aasland
gh-94630: Fixup sqlite3 argument spec docs for connection execute* me…
7e7a570 
…thods (GH-95319)

(cherry picked from commit 2b37395)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
miss-islington added a commit that referenced this pull request Jul 27, 2022
@miss-islington @erlend-aasland
gh-94630: Fixup sqlite3 argument spec docs for connection execute* me…
f281182 
…thods (GH-95319)

(cherry picked from commit 2b37395)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erlend-aasland @miss-islington @bedevere-bot