-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-94713 - Replacing while 1 with while True #94714
gh-94713 - Replacing while 1 with while True #94714
Conversation
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
Typically we don't accept changes like this, due to the churn involved. Is there any reason these need to be f-strings? |
These don't need to be f-strings. I just though that changing to f-strings would make the code better and so I did. Could u elaborate further on why changes like this aren't welcome ? |
There's always a chance for an error to be introduced in corner cases, and it makes any existing PRs difficult to apply. I'd definitely be okay with the |
Alright, I reverted back the f-strings changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although the name of this PR should probably be updated.
gh-94713: Replacing %-formatting and string concatenation with f-strings and replacing
while 1
withwhile True
.I don't think there is a need for a NEWS entry.