-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some deprecation warnings in Doc/conf.py #9
Conversation
I guess that it's related to my bug report http://bugs.python.org/issue29527 See also my PR #7. |
Codecov Report@@ Coverage Diff @@
## master #9 +/- ##
==========================================
- Coverage 82.37% 82.37% -0.01%
==========================================
Files 1427 1427
Lines 350948 350948
==========================================
- Hits 289090 289079 -11
- Misses 61858 61869 +11 Continue to review full report at Codecov.
|
Travis uses newest Sphinx. So changing |
@methane |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. Thanks.
* Fix some deprecation warnings in Doc/conf.py * Fix an rst error in Misc/NEWS Contributed by Ryan Gonzalez @kirbyfan64 (cherry picked from commit e7ffb99)
* Fix some deprecation warnings in Doc/conf.py * Fix an rst error in Misc/NEWS Contributed by Ryan Gonzalez @kirbyfan64 (cherry picked from commit e7ffb99)
* Fix some deprecation warnings in Doc/conf.py * Fix an rst error in Misc/NEWS Contributed by Ryan Gonzalez @kirbyfan64 (cherry picked from commit e7ffb99)
* Fix some deprecation warnings in Doc/conf.py * Fix an rst error in Misc/NEWS Contributed by Ryan Gonzalez @kirbyfan64 (cherry picked from commit e7ffb99)
9: Warn for using built-in open r=ltratt a=nanjekyejoannah Warn for file open. I was struggling to support the generic case assuming io.open doesnt exist. A warning is simpler to do assuming support for >=2.6. I added notes in the Google doc for this. Co-authored-by: Joannah Nanjekye <jnanjekye@python.org>
Implement read()
crosses fingers (My crappy computer never finishes building the docs, so let's see how far Travis goes...)