Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-46906: Mention native endian in PyFloat_Pack8() doc #31866

Merged
merged 1 commit into from
Mar 14, 2022
Merged

bpo-46906: Mention native endian in PyFloat_Pack8() doc #31866

merged 1 commit into from
Mar 14, 2022

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Mar 14, 2022 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Mar 14, 2022
@vstinner
Copy link
Member Author

@JelleZijlstra @mdickinson: It seems like PR #31832 wording was confusing, so here is a different wording. Is it less confusing?

@vstinner vstinner mentioned this pull request Mar 14, 2022
Closed
mdickinson
mdickinson approved these changes Mar 14, 2022
View reviewed changes
Copy link
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me. @JelleZijlstra?

JelleZijlstra
JelleZijlstra approved these changes Mar 14, 2022
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vstinner vstinner merged commit 11c25b8 into python:main Mar 14, 2022
@vstinner vstinner deleted the float_pack_endian branch March 14, 2022 15:51
@vstinner
Copy link
Member Author

I hesitated to add a new dedicated documentation for the PY_BIG_ENDIAN macro, but I didn't find any good place for it. So I documented it where it's mentioned, in the float docs.

Thanks for the review.

IMO the magic macro is less surprising with the documentation about its value.

carljm pushed a commit to carljm/cpython that referenced this pull request Mar 14, 2022
Merge branch 'main' into dictwatch
d22463b 
* main: (94 commits)
  Revert "bpo-46986: Upgrade bundled setuptools to 60.9.3 (pythonGH-31820)" (pythonGH-31879)
  bpo-30677: [doc] mention that os.mkdir() can raise FileNotFoundError (pythonGH-31548)
  git ignore Lib/site-packages (pythonGH-31862)
  bpo-31415: importtime was made by Inada Naoki (pythonGH-31875)
  bpo-46920: Remove code that has explainers why it was disabled (pythonGH-31813)
  bpo-46920: Remove disabled debug code added decades ago and likely unnecessary (pythonGH-31812)
  bpo-46920: Remove code that has no explainer why it was disabled (pythonGH-31814)
  bpo-46906: Mention native endian in PyFloat_Pack8() doc (pythonGH-31866)
  bpo-40280: select: Use NULL for empty fdset (pythonGH-31865)
  CI: Fix patchcheck (pythonGH-31708)
  bpo-46987: Remove _PySys_GetObjectId / _PySys_GetObjectId (pythonGH-31835)
  bpo-46994: Accept explicit contextvars.Context in asyncio create_task() API (pythonGH-31837)
  bpo-39829: Fix `__len__()` is called twice in list() constructor (pythonGH-31816)
  bpo-47003: Cleanup _overlapped module (pythonGH-31848)
  bpo-47004: Sync with importlib_metadata 4.11.3. (python#31854)
  bpo-46986: Upgrade bundled setuptools to 60.9.3 (pythonGH-31820)
  bpo-46985: Upgrade bundled pip to 22.0.4 (pythonGH-31819)
  bpo-46805: Add low level UDP socket functions to asyncio (pythonGH-31455)
  bpo-46995: Deprecate missing asyncio.Task.set_name() for third-party task implementations (pythonGH-31838)
  bpo-43215: Document Happy Eyeballs args of asyncio.open_connection (pythonGH-24525)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@mdickinson mdickinson mdickinson approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vstinner @mdickinson @JelleZijlstra @the-knights-who-say-ni @bedevere-bot