-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-89886: Clean up MACHDEP and _PYTHON_HOST_PLATFORM checks #30026
Conversation
|
There is no CI for cross building yet. |
Let's run it on the Emscripten container then; that's a cross-build, AFAIU. |
Accidentally, I've got some ARM toolchains installed. I'll throw it at them and see how it fares. |
Just out of curiosity: what distributions still don't have Autoconf so we need pregenerated |
Package managers are not our concern. We keep configure and other scripts in git to lower the barrier for contributors. Our |
Well, if this file cannot be removed because of specific requirements for its generation, maybe it can be marked as generated akin to outputs of Argument Clinic, Freeze, and Parser/asdl_c.py? It will allow GitHub to collapse it. By the way, I created #30031 to address this. |
BTW, this is a case where the |
Works for me. |
This PR is stale because it has been open for 30 days with no activity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the number of tests passed on my machine (420) I would say this looks ok to me.
But I cant test for all the supported architectures.
Also, I saw 61 fatal error
in the config.log
.
Is this ok?
BTW how do you check the results on configure? A part from running full test suite and checking the log.
I have no time to follow up this clean-up. Closing. |
https://bugs.python.org/issue45723