Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing spaces in os.walk example #29918

Merged
merged 2 commits into from
Feb 18, 2022
Merged

Conversation

BruceLee569
Copy link
Contributor

In the example of os.walk, a space is required between each sentence to distinguish words.

In the example of os.walk, a space is required between each sentence to distinguish words.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@BruceLee569

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@github-actions
Copy link

github-actions bot commented Jan 5, 2022

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Jan 5, 2022
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest retitling the PR to "Fix missing spaces in os.walk example"

@BruceLee569 BruceLee569 changed the title Update os.py Fix missing spaces in os.walk example Jan 24, 2022
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Planning to merge in a few days (cc @gvanrossum, another trivial docs fix).

Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not big on fixing typos in comments/docstrings (they tend to generate a lot of review noise for very little payback), and the fix here is unrelated to the point of the example. Then again, the damage is already done. I just hope that the contributor fixes something more significant in their next contribution.

@terryjreedy terryjreedy removed the stale Stale PR or inactive for long period of time. label Feb 17, 2022
Copy link
Member

@terryjreedy terryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that buggy code should be fixed even in docstring and that this does not need CLA. Please merge when CLA passes so we are done with this.

@terryjreedy terryjreedy merged commit 2a38e1a into python:main Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants