-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-89974: Support building with VS 2022 #29577
Conversation
cc @zooba I verified this, with this python can be compiled on VS 2022 without retargeting solution. |
How was it verified? In this case, MSBuild v143 must be downloaded and installed without any of the v142 components installed with it, or else it would naturally work because v142 is available. |
I only have v143 installed and it worked without any changes hence verified. |
@kumaraditya303 Alright, I'm verifying that; hold on. |
@kumaraditya303 No it does not work:
|
Apparently it was working for me locally, the windows team would verify it anyway, I am not a Visual Studio expert maybe I did something wrong, I use vscode and was compiling without errors, anyways Thanks |
We also need the change I mentioned in this post: https://bugs.python.org/issue45816#msg406635 Otherwise official release builds will break, and it'll cause annoying delays and nasty churn in the git history when we discover it too late ;) |
@zooba Added as part of the pull request. |
Thanks @thatbirdguythatuknownot for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
GH-94189 is a backport of this pull request to the 3.10 branch. |
…ythonGH-29577) (cherry picked from commit d930170) Co-authored-by: Crowthebird <78076854+thatbirdguythatuknownot@users.noreply.github.com>
https://bugs.python.org/issue45816