Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-45573: Detect stdlib extension modules in configure #29534

Closed
wants to merge 8 commits into from
Closed

bpo-45573: Detect stdlib extension modules in configure #29534

wants to merge 8 commits into from

Conversation

tiran
Copy link
Member

@tiran tiran commented Nov 12, 2021 •
edited
Loading

work in progress

configure now detects if a stdlib extension module is enabled/disabled and all prerequisites are available. Compiler and linker flags are passed to Makefile, makesetup, and setup.py.

For each extension module Makefile now contains up to three additional variables:

MODULE__SSL=yes
MODULE__SSL_CFLAGS=
MODULE__SSL_LDFLAGS=-lssl -lcrypto

Modules/Setup entries use the new variables. An entry like _ssl _ssl.c is sufficient to compile the ssl module as builtin. All compiler and linker flags are set by configure. The MODULE_EGG can be one of yes, disabled, missing, n/a.

Modules/_ssl.o: $(srcdir)/Modules/_ssl.c $(MODULE__SSL_DEPS) $(PYTHON_HEADERS) Modules/config.c
    $(CC) $(CCSHARED) $(PY_CFLAGS_NODIST) $(PY_CPPFLAGS) $(MODULE__SSL_CFLAGS) -c $(srcdir)/Modules/_ssl.c -o Modules/_ssl.o
Modules/_ssl$(EXT_SUFFIX):  Modules/_ssl.o
    $(BLDSHARED)  Modules/_ssl.o $(MODULE__SSL_LDFLAGS)  -o Modules/_ssl$(EXT_SUFFIX)

Missing modules: _curses, _curses_panel, _dbm, _sqlite3, _nis, _ctypes.

Signed-off-by: Christian Heimes christian@python.org

https://bugs.python.org/issue45573

erlend-aasland
erlend-aasland reviewed Nov 12, 2021
View reviewed changes
configure.ac Outdated Show resolved Hide resolved
tiran added 5 commits November 14, 2021 20:56
@tiran
bpo-45573: Detect stdlib extension modules in configure
207617e 
configure now detects if a stdlib extension module is enabled/disabled
and all prerequisites are available. Compiler and linker flags are
passed to Makefile, makesetup, and setup.py.

Missing modules: _curses, _curses_panel, _dbm, _sqlite3, _nis, _ctypes.

Signed-off-by: Christian Heimes <christian@python.org>
@tiran
Generate MODULE_BLOCK automatically
bcf8469
@tiran
Generate block for simple and static modules
7b0d162
@tiran
Split enabled/supported flags
513ff43
@tiran
Use CFLAGS, LDFLAGS, and DEPS from Makefile
836eb43
@tiran tiran mentioned this pull request Nov 17, 2021
Merged
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Dec 18, 2021
@tiran tiran closed this Jun 30, 2022
@tiran tiran mentioned this pull request Jan 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland left review comments

@corona10 corona10 Awaiting requested review from corona10 corona10 will be requested when the pull request is marked ready for review corona10 is a code owner

Assignees
No one assigned
Labels
awaiting core review DO-NOT-MERGE stale Stale PR or inactive for long period of time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tiran @erlend-aasland @the-knights-who-say-ni @bedevere-bot