Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.10] makefile: remove unused SGI_ABI variable (GH-29325) #29368

Merged
merged 1 commit into from
Nov 2, 2021
Merged

[3.10] makefile: remove unused SGI_ABI variable (GH-29325) #29368

merged 1 commit into from
Nov 2, 2021

Conversation

miss-islington
Copy link
Contributor

SGI_ABI support was removed in [1] but this variable was never removed
from the makefile. Currently, it is just a bad variable that does not
get replaced by the configure script.

[1] #3294

Signed-off-by: Filipe Laíns lains@riseup.net
(cherry picked from commit 38982ab)

Co-authored-by: Filipe Laíns lains@riseup.net

@FFY00 @miss-islington
makefile: remove unused SGI_ABI variable (pythonGH-29325)
d412a5b 
SGI_ABI support was removed in [1] but this variable was never removed
from the makefile. Currently, it is just a bad variable that does not
get replaced by the configure script.

[1] python#3294

Signed-off-by: Filipe Laíns <lains@riseup.net>
(cherry picked from commit 38982ab)

Co-authored-by: Filipe Laíns <lains@riseup.net>
@miss-islington
Copy link
Contributor Author

@FFY00 and @ambv: Status check is done, and it's a failure ❌ .

1 similar comment
@miss-islington
Copy link
Contributor Author

@FFY00 and @ambv: Status check is done, and it's a failure ❌ .

@bedevere-bot bedevere-bot mentioned this pull request Nov 2, 2021
Merged
@miss-islington
Copy link
Contributor Author

@FFY00 and @ambv: Status check is done, and it's a failure ❌ .

@miss-islington
Copy link
Contributor Author

@FFY00 and @ambv: Status check is done, and it's a success ✅ .

@ambv ambv merged commit 8d609b2 into python:3.10 Nov 2, 2021
@miss-islington miss-islington deleted the backport-38982ab-3.10 branch November 2, 2021 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@miss-islington @ambv @the-knights-who-say-ni @bedevere-bot @FFY00