Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-44019: Add test_all_exported_names for operator module #29124

Merged
merged 2 commits into from
Oct 21, 2021
Merged

bpo-44019: Add test_all_exported_names for operator module #29124

merged 2 commits into from
Oct 21, 2021

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Oct 21, 2021 •
edited by bedevere-bot
Loading

@corona10 corona10 requested a review from vstinner October 21, 2021 14:38
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Oct 21, 2021
vstinner
vstinner approved these changes Oct 21, 2021
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have a few minor comments.

Lib/test/test_operator.py Outdated Show resolved Hide resolved
Lib/test/test_operator.py Outdated Show resolved Hide resolved
@corona10 corona10 merged commit 37fad7d into python:main Oct 21, 2021
corona10 added a commit that referenced this pull request Oct 21, 2021
@corona10
Revert "bpo-44019: Add test_all_exported_names for operator module (G…
1dbe006 
…H-29124)"

This reverts commit 37fad7d.
@corona10 corona10 mentioned this pull request Oct 21, 2021
Closed
@corona10 corona10 deleted the bpo-44019 branch October 22, 2021 03:53
@anntzer anntzer mannequin mentioned this pull request Dec 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@corona10 @vstinner @the-knights-who-say-ni @bedevere-bot