bpo-43760: Check for tracing using 'bitwise or' instead of branch in dispatch. #28723
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About 1% faster
Use bitwise
or
instead of additional jump to handle tracing in dispatch.What was:
becomes:
use_tracing
is now either 0 or 255Special opcode 255 (DO_TRACING) handles tracing and then jumps to the original instruction.
The main complexity comes from needing access to the last instruction when tracing. This means that we update
frame->f_lasti
andnext_instr
at the start of the instruction, instead of at the end of the previous instruction.https://bugs.python.org/issue43760