bpo-24955: Fix webbrowser broken on Mac OS X when using the BROWSER variable #27751
Conversation
co-authored-by: Simon Conseil <sconseil>
There was a problem hiding this comment.
Please add the NEWS.d for this change
See: https://devguide.python.org/#quick-reference (How to use blurb tool)
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
There was a problem hiding this comment.
https://bugs.python.org/issue42255#msg380293
Since @ronaldoussoren wants to deprecate and remove it.
It looks like to good to change the PR
|
@hudelgado, we'll need this refactored on the current state of webbrowser.py which deprecated the |
|
I understand that it is sometimes not so simple, but as a user I've stumbled on this bug over multiple years and had to dig in really deep to figure out what even the real issue is for the errors I was having (finally ending up here). I feel like it might have been more pragmatic to merge and release this fix asap, and only after focus on deprecation with the proper notices as per procedure. |
|
Hello, sorry the long delay. If my changes are useful and still needed, I'm happy to change them and push for it. |
|
Closing this PR because it is no longer necessary, main branch is already updated as is 3.11. |
Fixes an issue with webbrowser by removing unused init method.
https://bugs.python.org/issue24955
co-authored-by: Simon Conseil
https://bugs.python.org/issue24955