Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-28556: Update to typing: treat subscripted generics as proxies #265

Merged
merged 1 commit into from
Feb 24, 2017
Merged

bpo-28556: Update to typing: treat subscripted generics as proxies #265

merged 1 commit into from
Feb 24, 2017

Conversation

ilevkivskyi
Copy link
Member

This a recent update from python/typing repo. See python/typing#393 for details.

This needs to be backported to 3.5 and 3.6

@ned-deily Guido would like to get this into 3.6.1

@ilevkivskyi ilevkivskyi mentioned this pull request Feb 23, 2017
Merged
@ilevkivskyi ilevkivskyi changed the title bpo-28556: Update to typing: treat subsctipted generics as proxies bpo-28556: Update to typing: treat subscripted generics as proxies Feb 23, 2017
@Mariatta Mariatta merged commit abb3b8a into python:master Feb 24, 2017
Mariatta pushed a commit to Mariatta/cpython that referenced this pull request Feb 24, 2017
@ilevkivskyi @Mariatta
Update to typing: treat subscripted generics as proxies (python#265)
a59a380 
(cherry picked from commit abb3b8a)
Mariatta pushed a commit to Mariatta/cpython that referenced this pull request Feb 24, 2017
@ilevkivskyi @Mariatta
Update to typing: treat subscripted generics as proxies (python#265)
2ad381f 
(cherry picked from commit abb3b8a)
@ilevkivskyi
Copy link
Member Author

@Mariatta Thank you for taking care of this!

Unfortunately, this PR introduced a small bug, that I spotted just now. I have made an additional PR #270 that fixes it. Sorry for troubles!

@Mariatta
Copy link
Member

Thanks @ilevkivskyi :) I cherry-picked this into the existing PRs
See GH-269 for the 3.5 backport and GH-268 for 3.6 backport.

@ilevkivskyi
Copy link
Member Author

Thanks @ilevkivskyi :) I cherry-picked this into the existing PRs
See GH-269 for the 3.5 backport and GH-268 for 3.6 backport.

Thank you Mariatta, this is perfect.

@ilevkivskyi ilevkivskyi deleted the update-typing-proxy branch February 24, 2017 19:51
Mariatta added a commit that referenced this pull request Feb 25, 2017
@Mariatta
[3.6] bpo-28556: Update to typing: treat subscripted generics as prox…
bea9d2f 
…ies (GH-265) (GH-268)

(cherry picked from commit abb3b8a)
(cherry picked from commit 365cb5b)
Mariatta added a commit that referenced this pull request Feb 25, 2017
@Mariatta
[3.5] bpo-28556: Update to typing: treat subscripted generics as prox…
bc33cd4 
…ies (GH-265) (GH-269)

(cherry picked from commit abb3b8a)
(cherry picked from commit 365cb5b)
akruis pushed a commit to akruis/cpython that referenced this pull request Jun 9, 2021
Stackless issue python#265: fix PyChannel_Send_M
32b481f 
The implementation was buggy. This affects only users of the C-API,
that call PyChannel_Send() and PyChannel_Send_nr() for calls from
outside of the interpreter (with no main-tasklet).
akruis pushed a commit to akruis/cpython that referenced this pull request Jun 9, 2021
Stackless issue python#265: fix PyChannel_Receive_M and tasklet_new
235fc6f 
If called from outside of the interpreter the behavior was undefined.
(Calling a C-function with wrong number of arguments).
akruis pushed a commit to akruis/cpython that referenced this pull request Jun 9, 2021
Stackless issue python#265: fix __reduce__ / __reduce_ex__
233e873 
Avoid undefined behavior, if Stackless classes implement __reduce__()
and __reduce_ex__() using a single C-function.
__reduce_ex__ now checks the type of its argument.
akruis pushed a commit to akruis/cpython that referenced this pull request Jun 9, 2021
Stackless issue python#265: fix the signature of tp_clear functions
d822483 
Return type is 'int', not 'void'.
akruis pushed a commit to akruis/cpython that referenced this pull request Jun 9, 2021
Stackless issue python#265: add missing arguments to C-function defin…
b62a6fe 
…itions

Most (getter)-functions, (setter)-functions and (PyCFunction)-functions
with flag METH_NOARGS lack an unused last argument, "void *" for
(getter) and (setter), "PyObject *" for (PyCFunction)-functions.
This commit adds these arguments.
akruis pushed a commit to akruis/cpython that referenced this pull request Jun 9, 2021
Stackless issue python#265: add missing arguments to C-function defin…
696b1ef 
…itions

Most (getter)-functions, (setter)-functions and (PyCFunction)-functions
with flag METH_NOARGS lack an unused last argument, "void *" for
(getter) and (setter), "PyObject *" for (PyCFunction)-functions.
This commit adds these arguments.
akruis pushed a commit to akruis/cpython that referenced this pull request Jun 11, 2021
@akruis
Stackless issue python#265: fix PyChannel_Send_M
3f54aa5 
The implementation was buggy. This affects only users of the C-API,
that call PyChannel_Send() and PyChannel_Send_nr() for calls from
outside of the interpreter (with no main-tasklet).
akruis pushed a commit to akruis/cpython that referenced this pull request Jun 11, 2021
@akruis
Stackless issue python#265: fix PyChannel_Receive_M and tasklet_new
04cff9c 
If called from outside of the interpreter the behavior was undefined.
(Calling a C-function with wrong number of arguments).
akruis pushed a commit to akruis/cpython that referenced this pull request Jun 11, 2021
@akruis
Stackless issue python#265: fix __reduce__ / __reduce_ex__
10c8679 
Avoid undefined behavior, if Stackless classes implement __reduce__()
and __reduce_ex__() using a single C-function.
__reduce_ex__ now checks the type of its argument.
akruis pushed a commit to akruis/cpython that referenced this pull request Jun 11, 2021
@akruis
Stackless issue python#265: fix the signature of tp_clear functions
f3739b9 
Return type is 'int', not 'void'.
akruis pushed a commit to akruis/cpython that referenced this pull request Jun 11, 2021
@akruis
Stackless issue python#265: add missing arguments to C-function defin…
cd48a58 
…itions

Most (getter)-functions, (setter)-functions and (PyCFunction)-functions
with flag METH_NOARGS lack an unused last argument, "void *" for
(getter) and (setter), "PyObject *" for (PyCFunction)-functions.
This commit adds these arguments.
akruis pushed a commit to akruis/cpython that referenced this pull request Jun 11, 2021
@akruis
Stackless issue python#265: Fix invalid function cast warnings
ba14f05 
Fix invalid function cast warnings with gcc 8 for method conventions
different from METH_NOARGS, METH_O and METH_VARARGS excluding Argument
Clinic generated code.
akruis added a commit to akruis/cpython that referenced this pull request Jun 11, 2021
@akruis
Stackless issue python#265: Fix (invalid) function cast warnings with…
b73166e 
… gcc 8

* fix PyChannel_Send_M

The implementation was buggy. This affects only users of the C-API,
that call PyChannel_Send() and PyChannel_Send_nr() for calls from
outside of the interpreter (with no main-tasklet).

* fix PyChannel_Receive_M and tasklet_new

If called from outside of the interpreter the behavior was undefined.
(Calling a C-function with wrong number of arguments).

* fix __reduce__ / __reduce_ex__

Avoid undefined behavior, if Stackless classes implement __reduce__()
and __reduce_ex__() using a single C-function.
__reduce_ex__ now checks the type of its argument.

* fix the signature of tp_clear functions

Return type is 'int', not 'void'.

* add missing arguments to C-function definitions

Most (getter)-functions, (setter)-functions and (PyCFunction)-functions
with flag METH_NOARGS lack an unused last argument, "void *" for
(getter) and (setter), "PyObject *" for (PyCFunction)-functions.
This commit adds these arguments.

* Fix invalid function cast warnings

Fix invalid function cast warnings with gcc 8 for method conventions
different from METH_NOARGS, METH_O and METH_VARARGS excluding Argument
Clinic generated code.
akruis pushed a commit to akruis/cpython that referenced this pull request Jun 11, 2021
Stackless issue python#265: merge changelog entries for this issue
4f89f4a
jaraco pushed a commit that referenced this pull request Dec 2, 2022
@dependabot-preview
Bump redis from 3.3.7 to 3.3.8 (#265)
2235de7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mariatta Mariatta Mariatta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ilevkivskyi @Mariatta @the-knights-who-say-ni