[3.9] bpo-38908: Fix issue when non runtime_protocol does not raise TypeError (GH-26067) #26075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvanrossum
approved these changes
May 12, 2021
|
Wait, @gvanrossum I just realised this is backwards incompatible with previous minor versions of 3.9. If someone previously used it incorrectly it will now throw an error. Should we revert this and keep it 3.10 only? (Sorry for the flip-flop!) |
Fidget-Spinner
added a commit
to Fidget-Spinner/cpython
that referenced
this pull request
May 12, 2021
… raise TypeError (pythonGH-26067) (pythonGH-26075)" This reverts commit 88136bb.
|
Alright, just in case you decide to, I already put the revert PR up at #26077. If you decide against it, please don't hesitate to close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit c40486a)
Co-authored-by: Yurii Karabas 1998uriyyo@gmail.com
https://bugs.python.org/issue38908
Automerge-Triggered-By: GH:gvanrossum