Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.9] bpo-43962: Fix _PyInterpreterState_IDIncref() (GH-25683) #25685

Closed

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Apr 28, 2021

_PyInterpreterState_IDIncref() now calls
_PyInterpreterState_IDInitref() and always increments id_refcount.
(cherry picked from commit 32c5a17)

Co-authored-by: Victor Stinner vstinner@python.org

https://bugs.python.org/issue43962

_PyInterpreterState_IDIncref() now calls
_PyInterpreterState_IDInitref() and always increments id_refcount.
(cherry picked from commit 32c5a17)

Co-authored-by: Victor Stinner <vstinner@python.org>
@miss-islington
Copy link
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

Copy link
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, regenerate the ABI

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@miss-islington
Copy link
Contributor Author

@vstinner: Status check is done, and it's a success ❌ .

@vstinner
Copy link
Member

@pablogsal:

Please, regenerate the ABI

I don't know how to do that: https://bugs.python.org/issue43725#msg392205

@pablogsal
Copy link
Member

I don't know how to do that: https://bugs.python.org/issue43725#msg392205

Check out the same docker container the CI uses and run the make regen-abidump target.

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label May 29, 2021
@vstinner
Copy link
Member

Check out the same docker container the CI uses

I don't know how to do that: https://bugs.python.org/issue43725#msg404019

Maybe I should just abandon this backport.

It's a little bit annoying of not being able to backport a fix because the CI says that it breaks the ABI, whereas the modified function is only part of the internal C API and its name starts with "_Py", so it's a private function.

@vstinner
Copy link
Member

I still don't know how to update the ABI. So I just abandon my bugfix backport, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting changes stale Stale PR or inactive for long period of time.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants