-
-
Notifications
You must be signed in to change notification settings - Fork 31k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.9] bpo-43962: Fix _PyInterpreterState_IDIncref() (GH-25683) #25685
Conversation
_PyInterpreterState_IDIncref() now calls _PyInterpreterState_IDInitref() and always increments id_refcount. (cherry picked from commit 32c5a17) Co-authored-by: Victor Stinner <vstinner@python.org>
@vstinner: Status check is done, and it's a success ✅ . |
@vstinner: Status check is done, and it's a success ✅ . |
1 similar comment
@vstinner: Status check is done, and it's a success ✅ . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good bot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, regenerate the ABI
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
@vstinner: Status check is done, and it's a success ❌ . |
I don't know how to do that: https://bugs.python.org/issue43725#msg392205 |
Check out the same docker container the CI uses and run the |
This PR is stale because it has been open for 30 days with no activity. |
I don't know how to do that: https://bugs.python.org/issue43725#msg404019 Maybe I should just abandon this backport. It's a little bit annoying of not being able to backport a fix because the CI says that it breaks the ABI, whereas the modified function is only part of the internal C API and its name starts with "_Py", so it's a private function. |
I still don't know how to update the ABI. So I just abandon my bugfix backport, sorry. |
_PyInterpreterState_IDIncref() now calls
_PyInterpreterState_IDInitref() and always increments id_refcount.
(cherry picked from commit 32c5a17)
Co-authored-by: Victor Stinner vstinner@python.org
https://bugs.python.org/issue43962