Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-20408: Fix memoryview() signature in docs. #24431

Merged
merged 1 commit into from
May 25, 2021
Merged

bpo-20408: Fix memoryview() signature in docs. #24431

merged 1 commit into from
May 25, 2021

Conversation

felixxm
Copy link
Contributor

@felixxm felixxm commented Feb 3, 2021 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Feb 3, 2021
Fidget-Spinner
Fidget-Spinner approved these changes Feb 4, 2021
View reviewed changes
Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

github-actions bot commented Mar 7, 2021

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Mar 7, 2021
@felixxm
Copy link
Contributor Author

felixxm commented Mar 11, 2021

This is not stale, I'm waiting for review.

@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Mar 12, 2021
@erlend-aasland erlend-aasland requested a review from ncoghlan May 25, 2021 08:00
@berkerpeksag berkerpeksag merged commit d18e5da into python:main May 25, 2021
@miss-islington
Copy link
Contributor

Thanks @felixxm for the PR, and @berkerpeksag for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-26355 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label May 25, 2021
@bedevere-bot
Copy link

GH-26356 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label May 25, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 25, 2021
@felixxm @miss-islington
bpo-20408: Fix memoryview() signature in docs (pythonGH-24431)
888f9c7 
(cherry picked from commit d18e5da)

Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 25, 2021
@felixxm @miss-islington
bpo-20408: Fix memoryview() signature in docs (pythonGH-24431)
74c8ff1 
(cherry picked from commit d18e5da)

Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
@berkerpeksag
Copy link
Member

Thank you!

berkerpeksag pushed a commit that referenced this pull request May 25, 2021
@miss-islington @felixxm
bpo-20408: Fix memoryview() signature in docs (GH-24431)
05f8ad0 
(cherry picked from commit d18e5da)

Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
berkerpeksag pushed a commit that referenced this pull request May 25, 2021
@miss-islington @felixxm
bpo-20408: Fix memoryview() signature in docs (GH-24431)
8accb8c 
(cherry picked from commit d18e5da)

Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
@felixxm felixxm deleted the fix-issue-20408 branch May 25, 2021 18:01
@felixxm
Copy link
Contributor Author

felixxm commented May 25, 2021

Thanks for checking 🚀

@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

@berkerpeksag berkerpeksag berkerpeksag approved these changes

@ncoghlan ncoghlan Awaiting requested review from ncoghlan

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@felixxm @miss-islington @bedevere-bot @berkerpeksag @Fidget-Spinner @erlend-aasland @the-knights-who-say-ni