Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc] Fix typo in the graphlib docs #22661

Merged
merged 4 commits into from
Oct 12, 2020
Merged

[doc] Fix typo in the graphlib docs #22661

merged 4 commits into from
Oct 12, 2020

Conversation

linchiwei123
Copy link
Contributor

@linchiwei123 linchiwei123 commented Oct 12, 2020 •
edited by miss-islington
Loading

Automerge-Triggered-By: @pablogsal

tirkarthi
tirkarthi reviewed Oct 12, 2020
View reviewed changes
Lib/graphlib.py Outdated
@@ -22,7 +22,8 @@ def __init__(self, node):


class CycleError(ValueError):
"""Subclass of ValueError raised by TopologicalSorterif cycles exist in the graph
"""Subclass of ValueError raised by :meth:`TopologicalSorter.prepare` if cycles
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sphinx style formatting is not necessarily used in docstrings. Other changes look good to me.

@tirkarthi tirkarthi requested a review from pablogsal October 12, 2020 13:45
pablogsal
pablogsal reviewed Oct 12, 2020
View reviewed changes
Lib/graphlib.py Outdated Show resolved Hide resolved
pablogsal
pablogsal reviewed Oct 12, 2020
View reviewed changes
Lib/graphlib.py Outdated Show resolved Hide resolved
@pablogsal pablogsal added the needs backport to 3.9 only security fixes label Oct 12, 2020
@miss-islington
Copy link
Contributor

@linchiwei123: Status check is done, and it's a failure ❌ .

@miss-islington
Copy link
Contributor

@linchiwei123: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit abe244c into python:master Oct 12, 2020
@miss-islington
Copy link
Contributor

Thanks @linchiwei123 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-22669 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Oct 12, 2020
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 12, 2020
@linchiwei123 @miss-islington
[doc] Fix typo in the graphlib docs (pythonGH-22661)
8a1a7a7 
Automerge-Triggered-By: @pablogsal
(cherry picked from commit abe244c)

Co-authored-by: linchiwei123 <40888469+linchiwei123@users.noreply.github.com>
pablogsal pushed a commit that referenced this pull request Oct 12, 2020
@miss-islington @linchiwei123
[doc] Fix typo in the graphlib docs (GH-22661) (GH-22669)
85d5964 
Automerge-Triggered-By: @pablogsal
(cherry picked from commit abe244c)

Co-authored-by: linchiwei123 <40888469+linchiwei123@users.noreply.github.com>

Co-authored-by: linchiwei123 <40888469+linchiwei123@users.noreply.github.com>
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@linchiwei123
[doc] Fix typo in the graphlib docs (pythonGH-22661)
67122b0 
Automerge-Triggered-By: @pablogsal
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@linchiwei123 @adorilson
[doc] Fix typo in the graphlib docs (pythonGH-22661)
0ab1b03 
Automerge-Triggered-By: @pablogsal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tirkarthi tirkarthi tirkarthi left review comments

@pablogsal pablogsal pablogsal approved these changes

Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@linchiwei123 @miss-islington @bedevere-bot @tirkarthi @pablogsal @the-knights-who-say-ni