-
-
Notifications
You must be signed in to change notification settings - Fork 31k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-64490: varargs support for argument clinic and refactor print with AC #18609
Conversation
169a88a
to
10a983e
Compare
8dca07a
to
239ad97
Compare
0ae57a2
to
deef95c
Compare
Codecov Report
@@ Coverage Diff @@
## master #18609 +/- ##
===========================================
+ Coverage 82.08% 83.20% +1.12%
===========================================
Files 1956 1571 -385
Lines 589394 414936 -174458
Branches 44457 44482 +25
===========================================
- Hits 483778 345267 -138511
+ Misses 95969 60023 -35946
+ Partials 9647 9646 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting PR. Thank you that taken this issue Batuhan! 👍 But it will take a time to make a review.
Misc/NEWS.d/next/Tools-Demos/2020-02-25-18-22-09.bpo-20291.AyrDiZ.rst
Outdated
Show resolved
Hide resolved
a9ffdcb
to
445eaa5
Compare
@serhiy-storchaka Could you review this PR if you have the time? If you are busy I can finish the review myself and try to land it so it reaches 3.11 :) |
@isidentical Can you rebase this and we can land it? |
🤖 New build scheduled with the buildbot fleet by @isidentical for commit 4186327 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
@isidentical Land if the buildbots are happy. Don't forget to also change the docs for the argument clinic in the devguide with any updates! |
The Doc/howto/clinic.rst docs still need updating. |
f(*args, /)
f(x, y, *args, /)
f(*args)
f(x, y, *args)
f(x, /, y, *args)
f(x, *args, y=3)
f(*args, y=3, z=5)
https://bugs.python.org/issue20291