-
-
Notifications
You must be signed in to change notification settings - Fork 31.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos and remove deprecated deprecation warning in library/ctypes doc. #17741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablogsal
approved these changes
Dec 29, 2019
Thanks for the PR @awecx ! |
Thanks @awecx for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
GH-17743 is a backport of this pull request to the 3.8 branch. |
GH-17744 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 29, 2019
(cherry picked from commit 32a12ae) Co-authored-by: Antoine <43954001+awecx@users.noreply.github.com>
miss-islington
added a commit
that referenced
this pull request
Dec 29, 2019
(cherry picked from commit 32a12ae) Co-authored-by: Antoine <43954001+awecx@users.noreply.github.com>
miss-islington
added a commit
that referenced
this pull request
Dec 29, 2019
(cherry picked from commit 32a12ae) Co-authored-by: Antoine <43954001+awecx@users.noreply.github.com>
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Jan 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the proposed changes made:
l.164: this warning should be removed as the exception is not raised anymore since 3.7 ;
l.627: grammar typo ;
l.925: grammar typo ;
l.1129: size should be highlighted as we are referring to the actual member name from the snippet.
No issue has been linked to this PR.