bpo-23894: Make rb'' strings work in lib2to3 #1724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
76b0e9d to
d330004
Compare
ambv
commented
May 22, 2017
| # Single-line ' or " string. | ||
| String = group(r"[uU]?[rR]?'[^\n'\\]*(?:\\.[^\n'\\]*)*'", | ||
| r'[uU]?[rR]?"[^\n"\\]*(?:\\.[^\n"\\]*)*"') |
There was a problem hiding this comment.
"String" didn't previously include b but this is suspicious to me. Why wouldn't it? That way b'' literals were only PseudoTokens (via ContStr), not actual Tokens (via String).
ned-deily
approved these changes
May 22, 2017
|
Tests are failing because I used an f-string in the test and lib2to3 is parsing that test file as part of fixers. f-strings are not supported yet in lib2to3. Switching to using a classic UPDATE: as expected, tests pass now. |
This partially solves bpo-23894.
ambv
added a commit
to ambv/cpython
that referenced
this pull request
May 22, 2017
This partially solves bpo-23894. (cherry picked from commit 0c4aca5)
ambv
added a commit
that referenced
this pull request
May 22, 2017
|
I was requested for a review, but after I completed my review, I see that the change was already merged :-D It's fine, don't worry. I just want to give my post-commit LGTM! Nice change. Thanks @ambv for taking care of 2to3 ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially solves bpo-23894. A separate PR coming later to support f-strings.