Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Change job name to 'build arm64' on Windows #129434

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Jan 29, 2025

The arm64 jobs only build, and don't test, but the job name is build and test (arm64):

image

https://github.com/python/cpython/actions/runs/13029187014/job/36344506016?pr=129426

Until we can add testing, let's update the name to just "build (arm64)":

image

https://github.com/python/cpython/actions/runs/13030013914/job/36347048011?pr=129434

@hugovk hugovk added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes infra CI, GitHub Actions, buildbots, Dependabot, etc. labels Jan 29, 2025
Copy link
Member

@Eclips4 Eclips4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks! Though maybe it makes sense to add a small comment to the code

@diegorusso
Copy link
Contributor

Thanks @hugovk. LGTM

@AA-Turner AA-Turner merged commit c67afb5 into python:main Jan 29, 2025
53 checks passed
@miss-islington-app
Copy link

Thanks @hugovk for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 29, 2025
(cherry picked from commit c67afb5)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Jan 29, 2025

GH-129439 is a backport of this pull request to the 3.13 branch.

@miss-islington-app
Copy link

Sorry, @hugovk and @AA-Turner, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker c67afb581eccb3ce20a4965c8f407fd2662b6bdf 3.12

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jan 29, 2025
@hugovk hugovk deleted the 3.14-windows-name-arm64 branch January 29, 2025 13:24
hugovk added a commit to hugovk/cpython that referenced this pull request Jan 29, 2025
@bedevere-app
Copy link

bedevere-app bot commented Jan 29, 2025

GH-129444 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Jan 29, 2025
AA-Turner pushed a commit that referenced this pull request Jan 29, 2025
…29444)

CI: Change job name to 'build arm64' on Windows (#129434)

(cherry picked from commit c67afb5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra CI, GitHub Actions, buildbots, Dependabot, etc. skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants