gh-91048: fix thread safety for asyncio stack introspection APIs #129399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging this as its been sitting idle for over a week now. |
kumaraditya303
commented
Feb 6, 2025
| if (TaskOrFuture_Check(state, fut) && TaskOrFuture_Check(state, waiter)) { | ||
| int res; | ||
| Py_BEGIN_CRITICAL_SECTION(fut); | ||
| res = future_awaited_by_add(state, (FutureObj *)fut, waiter); |
There was a problem hiding this comment.
Sorry, this should have been future_awaited_by_discard, fixing #129731.
I'm surprised that no tests failed, seems like test coverage is less for these functions...
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Feb 7, 2025
cmaloney
pushed a commit
to cmaloney/cpython
that referenced
this pull request
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
FutureObj *as all the other ones already do. In most cases, we avoid type checking on task which is guaranteed to be task or its subclass.