-
-
Notifications
You must be signed in to change notification settings - Fork 31k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-125722: Use long options for Sphinx #129039
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AA-Turner
added
docs
Documentation in the Doc dir
skip news
needs backport to 3.12
bug and security fixes
needs backport to 3.13
bugs and security fixes
labels
Jan 20, 2025
ezio-melotti
approved these changes
Jan 20, 2025
hugovk
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 🎉
Thanks @AA-Turner for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 20, 2025
(cherry picked from commit 4967fa6) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 20, 2025
(cherry picked from commit 4967fa6) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
GH-129041 is a backport of this pull request to the 3.13 branch. |
GH-129042 is a backport of this pull request to the 3.12 branch. |
hugovk
pushed a commit
that referenced
this pull request
Jan 20, 2025
hugovk
pushed a commit
that referenced
this pull request
Jan 20, 2025
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sphinx 7.3 added long options to
sphinx-build
, which this PR proposes using.Hugo added these in #118397, but had to revert them in #118401 (#118403). Nine months have passed and the median PR branch will probably have Sphinx 7.3, and if not we can use the "Update Branch" button, so I think we should try to use the long options again.
A
📚 Documentation preview 📚: https://cpython-previews--129039.org.readthedocs.build/