Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.13] gh-58956: Fix a frame refleak in bdb (GH-128190) #128947

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jan 17, 2025

(cherry picked from commit 767c89b)

Co-authored-by: Tian Gao gaogaotiantian@hotmail.com

(cherry picked from commit 767c89b)

Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
@gaogaotiantian
Copy link
Member

Hi @iritkatriel , sorry this was supposed to be a backport but the test actually found another potential leak - we never clear curframe_locals after leaving pdb, which could have a reference to a frame and keep all the frames alive. I added one line to clear it in forget(), it is simple and it actually does similar things as other changes so I did mot make a separate PR. Could you take a quick look?

Copy link
Member

@iritkatriel iritkatriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing is useful!

@gaogaotiantian gaogaotiantian merged commit dc77f19 into python:3.13 Jan 17, 2025
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants