Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-128911: Add PyImport_GetModuleAttrString() function #128912

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

gh-128911: Add PyImport_GetModuleAttrString() function #128912

wants to merge 6 commits into from
+178 −55

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jan 16, 2025 •
edited by github-actions bot
Loading

Remove "pycore_import.h" includes, no longer needed.

📚 Documentation preview 📚: https://cpython-previews--128912.org.readthedocs.build/

@vstinner
pythongh-128911: Add PyImport_GetModuleAttrString() function
5f320d1 
Remove "pycore_import.h" includes, no longer needed.
@bedevere-app bedevere-app bot mentioned this pull request Jan 16, 2025
Open
@vstinner
Copy link
Member Author

TODO: Write tests. But PyImport C API is currently not tested, we need maybe to first write tests for existing functions?

vstinner added a commit to vstinner/cpython that referenced this pull request Jan 16, 2025
@vstinner
pythongh-128912: Add tests on the PyImport C API
3a83056 
* Add Modules/_testlimitedcapi/import.c
* Add Lib/test/test_capi/test_import.py
@vstinner
Copy link
Member Author

But PyImport C API is currently not tested, we need maybe to first write tests for existing functions?

I wrote #128915 to add these tests first.

@vstinner vstinner mentioned this pull request Jan 17, 2025
Merged
@vstinner vstinner requested a review from a team as a code owner January 17, 2025 21:17
@vstinner
Copy link
Member Author

TODO: Write tests.

Done, I added tests.

corona10
corona10 approved these changes Jan 19, 2025
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@vstinner vstinner mentioned this pull request Jan 19, 2025
Open
6 tasks
@vstinner
Copy link
Member Author

I created a C API Working Group decision issue: capi-workgroup/decisions#53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@corona10 corona10 corona10 approved these changes

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner

@abalkin abalkin Awaiting requested review from abalkin abalkin is a code owner

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Assignees
No one assigned
Labels
awaiting merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vstinner @corona10 @erlend-aasland