Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-128770: fix ResourceWarning in test_pyrepl #128906

Merged
merged 1 commit into from
Jan 22, 2025
Merged

gh-128770: fix ResourceWarning in test_pyrepl #128906

merged 1 commit into from
Jan 22, 2025

Conversation

graingert
Copy link
Contributor

@graingert graingert commented Jan 16, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Jan 16, 2025
Open
@graingert graingert force-pushed the fix-resource-warning-in-test-pyrepl branch from 4536f9c to ca5eb67 Compare January 16, 2025 07:31
@graingert graingert changed the title gh-110012: Fix RuntimeWarning in test_socket gh-128770: fix ResourceWarning in test_pyrepl Jan 16, 2025
@bedevere-app bedevere-app bot mentioned this pull request Jan 16, 2025
Open
@graingert graingert marked this pull request as ready for review January 16, 2025 07:58
@graingert graingert mentioned this pull request Jan 16, 2025
Merged
@graingert graingert added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Jan 16, 2025
@graingert graingert requested a review from hugovk January 17, 2025 09:58
@pablogsal pablogsal merged commit 24c84d8 into python:main Jan 22, 2025
48 checks passed
@miss-islington-app
Copy link

Thanks @graingert for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 22, 2025
@graingert @miss-islington
pythongh-128770: fix ResourceWarning in test_pyrepl (pythonGH-128906)
79bba48 
(cherry picked from commit 24c84d8)

Co-authored-by: Thomas Grainger <tagrain@gmail.com>
@miss-islington-app
Copy link

Sorry, @graingert and @pablogsal, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 24c84d816f2f2ecb76b80328c3f1d8c05ead0b10 3.12

@bedevere-app
Copy link

bedevere-app bot commented Jan 22, 2025

GH-129179 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jan 22, 2025
@pablogsal
Copy link
Member

The new REPL is only on 3.13 so the 3.12 backport is not needed :)

@graingert graingert deleted the fix-resource-warning-in-test-pyrepl branch January 22, 2025 12:50
@graingert
Copy link
Contributor Author

Oh whoops

@hugovk hugovk removed the needs backport to 3.12 bug and security fixes label Jan 22, 2025
pablogsal pushed a commit that referenced this pull request Jan 22, 2025
@miss-islington
[3.13] gh-128770: fix ResourceWarning in test_pyrepl (GH-128906) (#12…
67971cd 
…9179)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal pablogsal approved these changes

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

@ambv ambv Awaiting requested review from ambv ambv is a code owner

@hugovk hugovk Awaiting requested review from hugovk

Assignees

@pablogsal pablogsal

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@graingert @pablogsal @hugovk