Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-128002: use _PyObject_SetMaybeWeakref when creating tasks in asyncio #128885

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

gh-128002: use _PyObject_SetMaybeWeakref when creating tasks in asyncio #128885

wants to merge 2 commits into from
+6 −0

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Jan 15, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Jan 15, 2025
Open
9 tasks
@colesbury
Copy link
Contributor

Can you add a test for this? I think something like the following would catch the bug:

  1. Create some tasks in the main thread
  2. Call all_tasks() in a different thread
  3. Check that you get all the tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@willingc willingc Awaiting requested review from willingc willingc is a code owner

@colesbury colesbury Awaiting requested review from colesbury

Assignees
No one assigned
Labels
awaiting core review skip news topic-asyncio topic-free-threading
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kumaraditya303 @colesbury