Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-127787: Move _PyUnicodeError_GetParams() to the internal C API #128803

Merged
merged 1 commit into from
Jan 14, 2025
Merged

gh-127787: Move _PyUnicodeError_GetParams() to the internal C API #128803

merged 1 commit into from
Jan 14, 2025
+9 −6

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jan 13, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Jan 13, 2025
Closed
@vstinner
Copy link
Member Author

vstinner commented Jan 13, 2025 •
edited
Loading

@picnixz @encukou: I don't see any reason to expose this function in the public C API. Is there a reason to have it in the public C API?

encukou
encukou approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's underscored so it's not public API. But I agree it's better in in internal/.

@vstinner vstinner merged commit 24a8d92 into python:main Jan 14, 2025
47 checks passed
@vstinner vstinner deleted the unicodeerr_getparams branch January 14, 2025 10:17
@picnixz
Copy link
Member

picnixz commented Jan 14, 2025

I think I put it there because I wasn't sure whether I'll need it in an extension module and then I forgot about it. Thanks for spotting this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@encukou encukou encukou approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vstinner @picnixz @encukou