Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: mark up json.dump() using parameter list #128482

Merged
merged 2 commits into from
Jan 4, 2025
Merged

Docs: mark up json.dump() using parameter list #128482

merged 2 commits into from
Jan 4, 2025

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jan 4, 2025 •
edited by hugovk
Loading

@erlend-aasland erlend-aasland requested a review from hugovk January 4, 2025 13:28
@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news labels Jan 4, 2025
@erlend-aasland
Copy link
Contributor Author

What do you think, Hugo?

hugovk
hugovk approved these changes Jan 4, 2025
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good. A few non-blocking wording suggestions.

Doc/library/json.rst Outdated Show resolved Hide resolved
Doc/library/json.rst Outdated Show resolved Hide resolved
Doc/library/json.rst Outdated Show resolved Hide resolved
Doc/library/json.rst Outdated Show resolved Hide resolved
Doc/library/json.rst Outdated Show resolved Hide resolved
@erlend-aasland @hugovk
Apply suggestions from Hugo's review
4e545d0 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@erlend-aasland erlend-aasland added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Jan 4, 2025
@erlend-aasland erlend-aasland marked this pull request as ready for review January 4, 2025 15:40
@erlend-aasland
Copy link
Contributor Author

Thanks Hugo; it definitely looks better with those suggestions.

@erlend-aasland erlend-aasland enabled auto-merge (squash) January 4, 2025 15:41
@erlend-aasland erlend-aasland merged commit a0088b4 into python:main Jan 4, 2025
33 checks passed
@erlend-aasland erlend-aasland deleted the docs/json-dump-param-list branch January 4, 2025 15:44
@miss-islington-app

This comment was marked as outdated.

Sign in to view
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 4, 2025
@erlend-aasland @hugovk @miss-islington
Docs: mark up json.dump() using parameter list (pythonGH-128482)
fd1a2cf 
(cherry picked from commit a0088b4)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Jan 4, 2025

GH-128486 is a backport of this pull request to the 3.13 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 4, 2025
@erlend-aasland @hugovk @miss-islington
Docs: mark up json.dump() using parameter list (pythonGH-128482)
9b10e56 
(cherry picked from commit a0088b4)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jan 4, 2025
@bedevere-app
Copy link

bedevere-app bot commented Jan 4, 2025

GH-128487 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Jan 4, 2025
erlend-aasland added a commit that referenced this pull request Jan 4, 2025
@miss-islington @erlend-aasland @hugovk
[3.13] Docs: mark up json.dump() using parameter list (GH-128482) (#1…
ff7ef94 
…28486)

(cherry picked from commit a0088b4)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
erlend-aasland added a commit that referenced this pull request Jan 4, 2025
@miss-islington @erlend-aasland @hugovk
[3.12] Docs: mark up json.dump() using parameter list (GH-128482) (#1…
731fc40 
…28487)

(cherry picked from commit a0088b4)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Jan 4, 2025
@erlend-aasland
Docs: amend json.dump() post pythongh-128482
a93ad5b
erlend-aasland added a commit that referenced this pull request Jan 4, 2025
@erlend-aasland
Docs: amend json.dump() post gh-128482 (#128489)
87ee760
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 4, 2025
@erlend-aasland @miss-islington
Docs: amend json.dump() post pythongh-128482 (pythonGH-128489)
59b58f2 
(cherry picked from commit 87ee760)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 4, 2025
@erlend-aasland @miss-islington
Docs: amend json.dump() post pythongh-128482 (pythonGH-128489)
9704cd1 
(cherry picked from commit 87ee760)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
erlend-aasland added a commit that referenced this pull request Jan 4, 2025
@miss-islington @erlend-aasland
[3.13] Docs: amend json.dump() post gh-128482 (GH-128489) (#128493)
62b4ca0 
(cherry picked from commit 87ee760)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
erlend-aasland added a commit that referenced this pull request Jan 4, 2025
@miss-islington @erlend-aasland
[3.12] Docs: amend json.dump() post gh-128482 (GH-128489) (#128494)
e3e4852 
(cherry picked from commit 87ee760)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 6, 2025
@erlend-aasland @hugovk @srinivasreddy
Docs: mark up json.dump() using parameter list (python#128482)
5f7ba82 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 6, 2025
@erlend-aasland @srinivasreddy
Docs: amend json.dump() post pythongh-128482 (python#128489)
1592145
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@erlend-aasland @hugovk @srinivasreddy
Docs: mark up json.dump() using parameter list (python#128482)
5aeee6f 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@erlend-aasland @srinivasreddy
Docs: amend json.dump() post pythongh-128482 (python#128489)
7c67994
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
Docs PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erlend-aasland @hugovk