Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-128456: Use -reorder-functions=cdsort for BOLT #128457

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

zanieb
Copy link
Contributor

@zanieb zanieb commented Jan 3, 2025

@zanieb
Copy link
Contributor Author

zanieb commented Jan 3, 2025

I don't believe this needs a news entry.

@erlend-aasland erlend-aasland enabled auto-merge (squash) January 3, 2025 20:46
@erlend-aasland erlend-aasland linked an issue Jan 3, 2025 that may be closed by this pull request
@erlend-aasland erlend-aasland merged commit 4974bbd into python:main Jan 3, 2025
46 of 47 checks passed
@erlend-aasland erlend-aasland added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Jan 3, 2025
@miss-islington-app

This comment was marked as outdated.

@miss-islington-app

This comment was marked as outdated.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 3, 2025
…honGH-128457)

'hfsort+' is deprecated in favor of 'cdsort'.
(cherry picked from commit 4974bbd)

Co-authored-by: Zanie Blue <contact@zanie.dev>
@bedevere-app
Copy link

bedevere-app bot commented Jan 3, 2025

GH-128461 is a backport of this pull request to the 3.13 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 3, 2025
…honGH-128457)

'hfsort+' is deprecated in favor of 'cdsort'.
(cherry picked from commit 4974bbd)

Co-authored-by: Zanie Blue <contact@zanie.dev>
@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jan 3, 2025
@bedevere-app
Copy link

bedevere-app bot commented Jan 3, 2025

GH-128462 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Jan 3, 2025
erlend-aasland pushed a commit that referenced this pull request Jan 3, 2025
…-128457) (#128462)

'hfsort+' is deprecated in favor of 'cdsort'.

(cherry picked from commit 4974bbd)

Co-authored-by: Zanie Blue <contact@zanie.dev>
erlend-aasland pushed a commit that referenced this pull request Jan 3, 2025
…-128457) (#128461)

'hfsort+' is deprecated in favor of 'cdsort'.

(cherry picked from commit 4974bbd)

Co-authored-by: Zanie Blue <contact@zanie.dev>
@zanieb
Copy link
Contributor Author

zanieb commented Jan 4, 2025

Just as a note, per the comment at #124948 (comment), this has no effect but silencing the deprecation warning as "reorder-functions=hfsort+ is transparently rewritten to cdsort".

WolframAlph pushed a commit to WolframAlph/cpython that referenced this pull request Jan 4, 2025
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BOLT uses deprecated option -reorder-functions=hfsort+
3 participants