GH-127010: Don't lazily track and untrack dicts #127027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 New build scheduled with the buildbot fleet by @markshannon for commit 3c11dba 🤖 If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
methane
reviewed
Nov 19, 2024
| @@ -581,8 +575,6 @@ tracking status of the object. | |||
| >>> gc.is_tracked({}) | |||
| False | |||
There was a problem hiding this comment.
No it is tracked. I'll update the docs.
|
The windows buildbot failures are unrelated to this PR. |
iritkatriel
reviewed
Nov 20, 2024
InternalDocs/garbage_collector.md
Outdated
| collector footprint of simple instances. Some examples of native types that | ||
| benefit from delayed tracking: | ||
| collector footprint of simple instances. Historically, both dictionaries and | ||
| tuples were untracked during garbage collection. Now it is only tuples: | ||
|
|
||
| - Tuples containing only immutable objects (integers, strings etc, |
There was a problem hiding this comment.
This is now a single-item bullet list.
iritkatriel
approved these changes
Nov 20, 2024
|
The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the code to lazily track and untrack dictionaries.
Benchmarks show a ~1% speedup.
📚 Documentation preview 📚: https://cpython-previews--127027.org.readthedocs.build/