Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.12] [3.13] GH-125789: fix fut._callbacks to always return a copy of callbacks (GH-125922) (GH-125976) #125977

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

miss-islington
Copy link
Contributor

GH-125789: fix fut._callbacks to always return a copy of callbacks (GH-125922)

Fix asyncio.Future._callbacks to always return a copy of the internal list of callbacks to avoid mutation from user code affecting the internal state.

(cherry picked from commit f54e1a2)

Co-authored-by: Kumar Aditya kumaraditya@python.org
(cherry picked from commit cae853e)

…of callbacks (pythonGH-125922) (pythonGH-125976)

pythonGH-125789: fix `fut._callbacks` to always return a copy of callbacks (pythonGH-125922)

Fix `asyncio.Future._callbacks` to always return a copy of the internal list of callbacks to avoid mutation from user code affecting the internal state.

(cherry picked from commit f54e1a2)

Co-authored-by: Kumar Aditya <kumaraditya@python.org>
(cherry picked from commit cae853e)
@picnixz
Copy link
Member

picnixz commented Oct 25, 2024

@kumaraditya303 Just to remember that for this one, you should probably remove the [3.13] mention in the merge commit message and PR title (I don't want to mess up with auto-gen titles so I won't change it now)

@kumaraditya303 kumaraditya303 merged commit 42927f7 into python:3.12 Oct 25, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants