-
-
Notifications
You must be signed in to change notification settings - Fork 31.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-123610: Added missing windows handle types to wintypes.py #124086
Conversation
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Hey @savannahostrowski, I’ve got a question I’d like to ask. |
@rruuaanng Thanks for the PR. We'll need to wait for a core developer to review it. Sometimes, PRs can take a while to be reviewed since many do this on a volunteer basis. Let's leave this PR open and give folks time to review. |
I'm the one who reviewed it last week. Since nothing seemed to have changed, I think this is fine. I had one interrogation namely, whether this warrants a NEWS entry and what granularity of details should be used. I suggested NOT to add a NEWS entry since we didn't even bother adding a NEWS entry for the previous handle types which are not even documented. However, a core dev will need to confirm this and to agree on merging this PR. We could, in a follow-up PR, add some doc indicating which handles are available and which are not. In the meantime, except waiting for such core dev, nothing more is needed. However, to spare CI resources, it would be preferrable not to merge the EDIT: I'll add the |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Agreed we don't really need NEWS for this, on the basis that anyone already using these types must have worked around it in some way, and the workarounds won't be broken by us adding the types here. It can be a secret little easter egg for someone to find (hopefully we aren't encouraging people to use the deprecated APIs that used these types...) |
Thanks to the reviewers for their efforts! Thanks for the merger of zooba! Maybe users will not use the above-mentioned abandoned API (to tell you quietly, Hmmmmm,they all actually used Linux). |
I'm puzzled why we're adding (apparently) very seldom used and deprecated APIs. |
The APIs aren't in Python, they're Win32 APIs, and we aren't adding them specifically. Users still have to access them with These are just type aliases so that users who directly translate the C definitions into |
ctypes.wintypes
#123610I fixed the issue with missing handles that was mentioned in #123610 and added the missing handle types.
My wrong commit made it difficult to reset. This is my last branch: #123721