gh-123341: Support tkinter.Event type subcript

[yowoda]

Adds __class_getitem__ to tkinter.Event and adds tkinter.Event to the list of generic types

• Issue: tkinter.Event is not subscriptable at runtime but generic in stub file #123341

[cpython-cla-bot]

All commit authors signed the Contributor License Agreement.

[bedevere-app]

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

[terryjreedy]

Is this the only class in tkinter that needs this treatment?

[yowoda]

Thanks for the review it's a bit late now, will be resolving everything tomorrow.

Is this significant enough to require a news entry? If so, let me know.

I couldn't find any other classes that need to implement this behaviour (in tkinter at least, the stdlib as a whole has plenty), so yeah, that should be the only class.

[terryjreedy]

Yes, add a news entry

[bedevere-app]

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

[bedevere-app]

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

[bedevere-app]

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

[yowoda]

I have made the requested changes; please review again

[bedevere-app]

Thanks for making the requested changes!

@sobolevn: please review the changes made to this pull request.

[yowoda]

Looks like tkinter.Event is actually not mentioned in the tkinter docs, should I remove the class reference?

[terryjreedy]

Our tkinter doc is deficient unless one considers it as incorporating other docs by reference, in which case Event is well documented. Its details are essential for working with events. But that does not help the role linker. Add ! after the first backtick, before tkinter. This suppresses the link attempt. That should fix "WARNING: py:class reference target not found: tkinter.Event [ref.class]". The blurb otherwise looks great to me.

[serhiy-storchaka]

LGTM.

[yowoda]

Should be good to go now