Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-122170: Handle ValueError raised by os.stat in linecache #122176

Merged
merged 8 commits into from
Jul 27, 2024
Merged

gh-122170: Handle ValueError raised by os.stat in linecache #122176

merged 8 commits into from
Jul 27, 2024

Conversation

picnixz
Copy link
Member

@picnixz picnixz commented Jul 23, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Jul 23, 2024
Closed
@picnixz picnixz changed the title gh-122170: Handle long filenames on Windows platforms in linecache gh-122170: Handle ValueError raised by os.stat in linecache Jul 24, 2024
@picnixz picnixz mentioned this pull request Jul 24, 2024
Closed
@picnixz picnixz requested a review from serhiy-storchaka July 24, 2024 14:24
@picnixz picnixz added the stdlib Python modules in the Lib dir label Jul 25, 2024
serhiy-storchaka
serhiy-storchaka reviewed Jul 25, 2024
View reviewed changes
Lib/test/test_linecache.py Outdated Show resolved Hide resolved
Lib/test/test_linecache.py Outdated Show resolved Hide resolved
Lib/linecache.py Outdated Show resolved Hide resolved
serhiy-storchaka
serhiy-storchaka approved these changes Jul 27, 2024
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@serhiy-storchaka serhiy-storchaka enabled auto-merge (squash) July 27, 2024 10:02
@serhiy-storchaka serhiy-storchaka merged commit 7a6d4cc into python:main Jul 27, 2024
36 checks passed
@picnixz picnixz deleted the fix-linecache-valueerror branch July 27, 2024 10:18
@picnixz
Copy link
Member Author

picnixz commented Jul 27, 2024

@serhiy-storchaka Should I backport this one to 3.12 and 3.13? (I would say yes)

@serhiy-storchaka serhiy-storchaka added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Jul 27, 2024
@miss-islington-app
Copy link

Thanks @picnixz for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @picnixz for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 27, 2024
@picnixz @miss-islington
pythongh-122170: Handle ValueError raised by os.stat() in linecache (p…
84f35b9 
…ythonGH-122176)

(cherry picked from commit 7a6d4cc)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Jul 27, 2024

GH-122348 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 27, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 27, 2024
@picnixz @miss-islington
pythongh-122170: Handle ValueError raised by os.stat() in linecache (p…
e99304b 
…ythonGH-122176)

(cherry picked from commit 7a6d4cc)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Jul 27, 2024

GH-122349 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Jul 27, 2024
@serhiy-storchaka
Copy link
Member

Yes, this can be considered as a bug fix, although very minor.

serhiy-storchaka pushed a commit that referenced this pull request Jul 27, 2024
@miss-islington @picnixz
[3.12] gh-122170: Handle ValueError raised by os.stat() in linecache (G…
2e37d67 
…H-122176) (GH-122349)

(cherry picked from commit 7a6d4cc)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
serhiy-storchaka pushed a commit that referenced this pull request Jul 27, 2024
@miss-islington @picnixz
[3.13] gh-122170: Handle ValueError raised by os.stat() in linecache (G…
3648a94 
…H-122176) (GH-122348)

(cherry picked from commit 7a6d4cc)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
stdlib Python modules in the Lib dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@picnixz @serhiy-storchaka