Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-120974: Use common freelist code in asyncio #122132

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

colesbury
Copy link
Contributor

@colesbury colesbury commented Jul 22, 2024

This refactors asyncio to use the common freelist helper functions and macros. As a side effect, the freelist for _asyncio.Future is now re-enabled in the free-threaded build.

This refactors asyncio to use the common freelist helper functions and
macros. As a side effect, the freelist for _asyncio.Future is now
re-enabled in the free-threaded build.
@colesbury
Copy link
Contributor Author

!buildbot Ubuntu refleaks

@bedevere-bot
Copy link

The regex 'Ubuntu refleaks' did not match any buildbot builder. Is the requested builder in the list of stable builders?

@colesbury
Copy link
Contributor Author

!buildbot refleaks

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @colesbury for commit 21cdcd2 🤖

The command will test the builders whose names match following regular expression: refleaks

The builders matched are:

  • AMD64 Windows11 Refleaks PR
  • AMD64 Fedora Rawhide NoGIL refleaks PR
  • s390x RHEL7 Refleaks PR
  • aarch64 Fedora Stable Refleaks PR
  • ARM64 MacOS M1 Refleaks NoGIL PR
  • PPC64LE RHEL8 Refleaks PR
  • PPC64LE Fedora Rawhide NoGIL refleaks PR
  • PPC64LE CentOS9 Refleaks PR
  • s390x Fedora Refleaks PR
  • AMD64 RHEL8 Refleaks PR
  • aarch64 CentOS9 Refleaks PR
  • s390x RHEL8 Refleaks PR
  • AMD64 CentOS9 Refleaks PR
  • s390x Fedora Rawhide Refleaks PR
  • aarch64 Fedora Rawhide NoGIL refleaks PR
  • AMD64 Fedora Rawhide Refleaks PR
  • aarch64 RHEL8 Refleaks PR
  • AMD64 Ubuntu NoGIL Refleaks PR
  • PPC64LE RHEL7 Refleaks PR
  • PPC64LE Fedora Rawhide Refleaks PR
  • aarch64 Fedora Rawhide Refleaks PR
  • AMD64 RHEL7 Refleaks PR
  • AMD64 Fedora Stable Refleaks PR
  • PPC64LE Fedora Stable Refleaks PR

Copy link
Contributor

@kumaraditya303 kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a look at the new freelist code as well. This LGTM.

@kumaraditya303 kumaraditya303 merged commit c908d1f into python:main Jul 23, 2024
55 of 58 checks passed
@colesbury colesbury deleted the gh-120974-asyncio-freelist branch July 23, 2024 16:37
nohlson pushed a commit to nohlson/cpython that referenced this pull request Jul 24, 2024
This refactors asyncio to use the common freelist helper functions and
macros. As a side effect, the freelist for _asyncio.Future is now
re-enabled in the free-threaded build.
nohlson pushed a commit to nohlson/cpython that referenced this pull request Jul 24, 2024
This refactors asyncio to use the common freelist helper functions and
macros. As a side effect, the freelist for _asyncio.Future is now
re-enabled in the free-threaded build.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants