Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-119169: Speed up os.fwalk(topdown=False) #121433

Closed
wants to merge 2 commits into from

Conversation

barneygale
Copy link
Contributor

@barneygale barneygale commented Jul 6, 2024

Add entries to the stack while iterating over os.scandir() results, rather than afterwards. This removes the need for an entries list and some zipping.

Requires #119473.

Add entries to the stack while iterating over `os.scandir()` results,
rather than afterwards. This removes the need for an `entries` list and
some zipping.
@barneygale barneygale added the performance Performance or resource usage label Jul 6, 2024
@barneygale
Copy link
Contributor Author

Closing because reversing sibling traversal order isn't kosher - see discussion on #119473.

@barneygale barneygale closed this Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance or resource usage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant