Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-121035: Update PNG image for logging flow diagram. #121323

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

vsajip
Copy link
Member

@vsajip vsajip commented Jul 3, 2024

@vsajip vsajip added docs Documentation in the Doc dir skip news labels Jul 3, 2024
@vsajip vsajip self-assigned this Jul 3, 2024
@nineteendo
Copy link
Contributor

nineteendo commented Jul 3, 2024

Is it intentional to decrease the resolution? I don't see any other changes. Slice comparison doesn't work on GitHub because of that.

@vsajip
Copy link
Member Author

vsajip commented Jul 3, 2024

Is it intentional to decrease the resolution?

Not especially. This image is not currently shown in the documentation (it's there in case some browsers can't display the SVG properly). It has been produced using ImageMagick from the SVG diagram.

@vsajip vsajip merged commit 26d24ee into python:main Jul 3, 2024
29 checks passed
@vsajip vsajip deleted the logging-flow-image branch July 3, 2024 11:33
vsajip added a commit to vsajip/cpython that referenced this pull request Jul 3, 2024
…ythonGH-121323)

(cherry picked from commit 26d24ee)

Co-authored-by: Vinay Sajip <vinay_sajip@yahoo.co.uk>
vsajip added a commit to vsajip/cpython that referenced this pull request Jul 3, 2024
…ythonGH-121323)

(cherry picked from commit 26d24ee)

Co-authored-by: Vinay Sajip <vinay_sajip@yahoo.co.uk>
@bedevere-app
Copy link

bedevere-app bot commented Jul 3, 2024

GH-121324 is a backport of this pull request to the 3.13 branch.

@bedevere-app
Copy link

bedevere-app bot commented Jul 3, 2024

GH-121325 is a backport of this pull request to the 3.12 branch.

vsajip added a commit that referenced this pull request Jul 3, 2024
vsajip added a commit that referenced this pull request Jul 3, 2024
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants