Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-121027: Add a future warning in functools.partial.__get__ #121086

Merged
merged 2 commits into from
Jun 27, 2024
Merged

gh-121027: Add a future warning in functools.partial.__get__ #121086

merged 2 commits into from
Jun 27, 2024

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jun 27, 2024 •
edited by github-actions bot
Loading

@serhiy-storchaka serhiy-storchaka added the needs backport to 3.13 bugs and security fixes label Jun 27, 2024
@bedevere-app bedevere-app bot mentioned this pull request Jun 27, 2024
Closed
Yhg1s
Yhg1s approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@Yhg1s Yhg1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really that happy about getting this into 3.13 at this stage, but whatever, it's only a FutureWarning on something that's a bad idea anyway (by which I mean using functools.partial in the first place, as well as using it as a class attribute.)

Doc/whatsnew/3.13.rst Outdated Show resolved Hide resolved
@serhiy-storchaka @Yhg1s
Update Doc/whatsnew/3.13.rst
fa4be09 
Co-authored-by: T. Wouters <thomas@python.org>
@Yhg1s Yhg1s enabled auto-merge (squash) June 27, 2024 11:41
@nineteendo nineteendo mentioned this pull request Jun 27, 2024
Merged
@Yhg1s Yhg1s merged commit db96edd into python:main Jun 27, 2024
36 checks passed
@miss-islington-app
Copy link

Thanks @serhiy-storchaka for the PR, and @Yhg1s for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 27, 2024
@serhiy-storchaka @miss-islington
pythongh-121027: Add a future warning in functools.partial.__get__ (p…
872bb29 
…ythonGH-121086)

(cherry picked from commit db96edd)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Jun 27, 2024

GH-121092 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jun 27, 2024
Yhg1s pushed a commit that referenced this pull request Jun 27, 2024
@miss-islington @serhiy-storchaka
[3.13] gh-121027: Add a future warning in functools.partial.__get__ (G…
49e5740 
…H-121086) (#121092)

gh-121027: Add a future warning in functools.partial.__get__ (GH-121086)
(cherry picked from commit db96edd)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
@serhiy-storchaka @mrahtz
pythongh-121027: Add a future warning in functools.partial.__get__ (p…
da39581 
…ython#121086)
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@serhiy-storchaka @noahbkim
pythongh-121027: Add a future warning in functools.partial.__get__ (p…
5a9c740 
…ython#121086)
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@serhiy-storchaka @estyxx
pythongh-121027: Add a future warning in functools.partial.__get__ (p…
86a23c9 
…ython#121086)
@mgorny mgorny mentioned this pull request Jul 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yhg1s Yhg1s Yhg1s approved these changes

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serhiy-storchaka @Yhg1s