Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typo fix for pegen meta parser #120720

Merged
merged 1 commit into from
Jun 19, 2024
Merged

typo fix for pegen meta parser #120720

merged 1 commit into from
Jun 19, 2024

Conversation

yf-yang
Copy link
Contributor

@yf-yang yf-yang commented Jun 19, 2024

Follows pegen fix we-like-parsers/pegen#102

@cpython-cla-bot CPython CLA Bot
Copy link

cpython-cla-bot bot commented Jun 19, 2024 •
edited
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Jun 19, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app
Copy link

bedevere-app bot commented Jun 19, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app
Copy link

bedevere-app bot commented Jun 19, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@nineteendo
Copy link
Contributor

Could you avoid force pushing when not strictly necessary? Also note that suggestions can be applied directly from GitHub.

In order to keep the commit history intact, please avoid squashing or amending history and then force-pushing to the PR. Reviewers often want to look at individual commits.

@yf-yang
Copy link
Contributor Author

yf-yang commented Jun 19, 2024

Sure but seems doesn't matter in this PR?

lysnikolaou
lysnikolaou approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @yf-yang!

@lysnikolaou lysnikolaou merged commit ace2045 into python:main Jun 19, 2024
43 checks passed
@yf-yang yf-yang mentioned this pull request Jun 20, 2024
Merged
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
@yf-yang @mrahtz
Fix types in pegen parser generator (pythonGH-120720)
38ce7b8
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@yf-yang @noahbkim
Fix types in pegen parser generator (pythonGH-120720)
72eb992
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@yf-yang @estyxx
Fix types in pegen parser generator (pythonGH-120720)
fe61147
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nineteendo nineteendo nineteendo left review comments

@lysnikolaou lysnikolaou lysnikolaou approved these changes

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yf-yang @nineteendo @lysnikolaou