Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-120686: remove unused internal c api functions #120687

Merged
merged 4 commits into from
Jun 27, 2024
Merged

gh-120686: remove unused internal c api functions #120687

merged 4 commits into from
Jun 27, 2024

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Jun 18, 2024 •
edited by bedevere-app bot
Loading

@iritkatriel iritkatriel requested a review from markshannon as a code owner June 18, 2024 12:47
@bedevere-app bedevere-app bot mentioned this pull request Jun 18, 2024
Closed
markshannon
markshannon approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

It will be good to get rid of _Py_Identifier completely.

@iritkatriel iritkatriel merged commit 6f7acaa into python:main Jun 27, 2024
36 checks passed
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
@iritkatriel @mrahtz
pythongh-120686: remove unused internal c api functions (python#120687)
c1c34c3
@vstinner
Copy link
Member

vstinner commented Jul 1, 2024

It will be good to get rid of _Py_Identifier completely.

I tried but failed so far: https://discuss.python.org/t/c-api-how-much-private-is-the-private-py-identifier-api/29190

noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@iritkatriel @noahbkim
pythongh-120686: remove unused internal c api functions (python#120687)
964fda7
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@iritkatriel @estyxx
pythongh-120686: remove unused internal c api functions (python#120687)
144ab76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markshannon markshannon markshannon approved these changes

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Removed unused internal C API functions
3 participants
@iritkatriel @vstinner @markshannon