-
-
Notifications
You must be signed in to change notification settings - Fork 31.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-120385: Fix reference leak in symtable #120386
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I confirm that the change fix the refleak.
Without this change, ./python -m test -R 3:3 test_coroutines
leaks. With this change, it no longer leaks.
|
Thanks for the fix! Sorry I forgot to run the buildbots before merging my change. |
Decref 'new_ste' if symtable_visit_annotations() fails.
Decref 'new_ste' if symtable_visit_annotations() fails.
Decref 'new_ste' if symtable_visit_annotations() fails.
test_coroutines
leaks references #120385