Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT: ignore some failing test_logging tests #120375

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

diegorusso
Copy link
Contributor

Some of the test_logging tests are failing in the emulated linux environment on GitHub independently from the changes of the PR. Add them to the ignore list.

Some of the test_logging tests are failing in the emulated linux
environment on GitHub indipendently from the changes of the PR
Add them to the ignore list.
test.test_venv.BasicTest.test_zippath_from_non_installed_posix
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My editor added automatically the new line at the end of the file.

@brandtbucher brandtbucher self-assigned this Jun 11, 2024
@brandtbucher brandtbucher added type-bug An unexpected behavior, bug, or error tests Tests in the Lib/test dir topic-JIT skip issue skip news labels Jun 11, 2024
@nineteendo
Copy link
Contributor

Thanks, the failed workflow notifications were getting annoying.

Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@brandtbucher brandtbucher merged commit 07daaf1 into python:main Jun 19, 2024
66 checks passed
@brandtbucher brandtbucher added the needs backport to 3.13 bugs and security fixes label Jun 24, 2024
@miss-islington-app
Copy link

Thanks @diegorusso for the PR, and @brandtbucher for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 24, 2024
(cherry picked from commit 07daaf1)

Co-authored-by: Diego Russo <diego.russo@arm.com>
@bedevere-app
Copy link

bedevere-app bot commented Jun 24, 2024

GH-120977 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jun 24, 2024
@diegorusso diegorusso deleted the jit-ignore-test-logging-tests branch June 25, 2024 15:34
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip issue skip news tests Tests in the Lib/test dir topic-JIT type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants